Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
You can already achieve this behaviour by pointing the input and output args to the same file. IMHO adding this flag increases complexity of the cli without improving it. |
|
You mean something like "guetzli beens.png" should automaticly create a compressed file called beens.jpg if there is not output file given? |
|
I disagree with @romainmenke on this one. Adding an overwrite flag does improve the program and its CLI, at the cost of only a small increase in complexity. It doesn't break default behaviour since it needs to be explicitly called. It's ideal for situations where a user wants to compress an existing JPG file without ending up with a second copy of the same image. |
|
@gtuk Try
So this adds extra code that has to be maintained without adding functionality. Such a flag would make sense in a program that does batch compressions and alters filenames to prevent overwrites. Since Guetzli does neither I personally don't really see the added value. |
No description provided.